[squid-dev] [PATCH] Avoid memory leaks when a certificate validator is used with SslBump

[Christos Tsantilas]

On 12/13/2015 10:11 AM, Amos Jeffries wrote:
> On 11/12/2015 4:09 a.m., Christos Tsantilas wrote:
>> When a certificate validator was used, sslCrtvdHandleReplyWrapper
>> delivered validator response directly to the Ssl::PeerConnector job
>> using job's Ssl::CertValidationHelper::CVHCB callback. If that
>> synchronous call happened to be the last job call, then
>> Ssl::PeerConnector::done() would become true for the job, as it should,
>> but nobody would notice that the PeerConnector job object should be
>> deleted, and the object would leak.
>>
>> This fix converts CVHCB into an async job call to avoid direct,
>> unprotected job calls in this context.
>>
>> This is a Measurement Factory project.
>
> +1.

The patch applied to trunk, the fixed bug is enough serious.
I am attaching the squid-3.5 patch.

>
> Amos
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: High_Memory_Usage_in_Squid-3.5-t3.patch
Type: text/x-patch
Size: 22520 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20151213/b0932475/attachment.bin>