[squid-dev] [PATCH] Avoid memory leaks when a certificate validator is used with SslBump

[Amos Jeffries]

On 11/12/2015 4:09 a.m., Christos Tsantilas wrote:
> When a certificate validator was used, sslCrtvdHandleReplyWrapper
> delivered validator response directly to the Ssl::PeerConnector job
> using job's Ssl::CertValidationHelper::CVHCB callback. If that
> synchronous call happened to be the last job call, then
> Ssl::PeerConnector::done() would become true for the job, as it should,
> but nobody would notice that the PeerConnector job object should be
> deleted, and the object would leak.
> 
> This fix converts CVHCB into an async job call to avoid direct,
> unprotected job calls in this context.
> 
> This is a Measurement Factory project.

+1.

Amos