[squid-dev] [PATCH] Avoid memory leaks when a certificate validator is used with SslBump

[Amos Jeffries]

On 14/12/2015 6:16 a.m., Christos Tsantilas wrote:
> Avoid memory leaks when a certificate validator is used with SslBump
> 
> When a certificate validator was used, sslCrtvdHandleReplyWrapper delivered
> validator response directly to the Ssl::PeerConnector job using job's
> Ssl::CertValidationHelper::CVHCB callback. If that synchronous call happened
> to be the last job call, then Ssl::PeerConnector::done() would become true
> for the job, as it should, but nobody would notice that the PeerConnector
> job object should be deleted, and the object would leak.
> 
> This fix converts CVHCB into an async job call to avoid direct, unprotected
> job calls in this context.
> 
> This is a Measurement Factory project.
> 

Applied to 3.5 as rev.13966

Amos