[squid-dev] [PATCH] remove ip/Qos.cci
Amos Jeffries
squid3 at treenet.co.nz
Sun Jan 8 00:54:06 UTC 2017
On 2017-01-08 06:33, Kinkie wrote:
> Looks good, except that
>
> +Qos::Config() {STUB}
>
> Surrounding the STUB macro in brackets is not the common style
> (although it is harmless and could actually be a good idea)
>
> +1, possibly with this change
>
There was some reason for that which I've forgotten the details of, but
one of astyle, doxygen, or one of the weird compilers had issues with
constructors and destructors having the {} inside the STUB macro.
Placing them around like that fixed it.
Amos
More information about the squid-dev
mailing list