[squid-dev] [PATCH] remove ip/Qos.cci

Kinkie gkinkie at gmail.com
Sat Jan 7 17:33:00 UTC 2017


Looks good, except that

+Qos::Config() {STUB}

Surrounding the STUB macro in brackets is not the common style
(although it is harmless and could actually be a good idea)

+1, possibly with this change

On Sat, Jan 7, 2017 at 11:46 AM, Amos Jeffries <squid3 at treenet.co.nz> wrote:
> This patch removes ip/Qos.cci file moving its content to ip/QosConfig.cc.
>
> Also, move the stub file to src/tests/stub_libip.cc and update to use
> tests/STUB.h interface.
>
> Amos
>
> _______________________________________________
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
>



-- 
    Francesco


More information about the squid-dev mailing list