[squid-dev] checklist->conn assertion in DestinationIp.cc

[Eduard Bagdasaryan]

Addressed your comments in [t2] patch.
Also polished ACLFilledChecklist::fd(int) similarly.

Eduard.

2016-01-13 8:05 GMT+03:00 Amos Jeffries <squid3 at treenet.co.nz>:
> in src/acl/DestinationIp.cc
>
> * please use a "const auto" local variable to store checklist->conn().
>   - that way you can avoid three de-references and method calls.
>
>
> in src/acl/FilledChecklist.cc
>
> * ACLFilledChecklist::conn() does not need to check "conn_ != nullptr"
>   - cbdataReferenceValid() handles that fine for this usage.
>
> * ACLFilledChecklist::fd() needs to use conn() consistently.
>   - that may mean a "const auto" temporary variable to avoid multiple
> conn() calls and dereferences.
>   - also the "!= nullptr" parts can be erased now. RefCount no longer has
> the issue that !=NULL was needed for.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160113/5c09ca1a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SQUID-37-assertion-in-destination-ip-t2.patch
Type: text/x-patch
Size: 4931 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160113/5c09ca1a/attachment.bin>