<html>
<head>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Addressed your comments in [t2] patch.<br>
Also polished ACLFilledChecklist::fd(int) similarly.<br>
<br>
Eduard.<br>
<br>
<meta http-equiv="content-type" content="text/html; charset=utf-8">
2016-01-13 8:05 GMT+03:00 Amos Jeffries
<a class="moz-txt-link-rfc2396E" href="mailto:squid3@treenet.co.nz"><squid3@treenet.co.nz></a>: <br>
<blockquote type="cite">
<pre>in src/acl/DestinationIp.cc
* please use a "const auto" local variable to store checklist->conn().
- that way you can avoid three de-references and method calls.
in src/acl/FilledChecklist.cc
* ACLFilledChecklist::conn() does not need to check "conn_ != nullptr"
- cbdataReferenceValid() handles that fine for this usage.
* ACLFilledChecklist::fd() needs to use conn() consistently.
- that may mean a "const auto" temporary variable to avoid multiple
conn() calls and dereferences.
- also the "!= nullptr" parts can be erased now. RefCount no longer has
the issue that !=NULL was needed for.</pre>
</blockquote>
<br>
</body>
</html>