[squid-dev] [PATCH] keep track of the size of uploads done with CONNECT

Amos Jeffries squid3 at treenet.co.nz
Sun Sep 27 10:32:46 UTC 2015


On 23/09/2015 5:18 a.m., Aymeric Vincent wrote:
> 
> Hi,
> 
> Amos Jeffries <squid3 at treenet.co.nz> writes:
> 
>> This looks okay in itself. I am just a little suspicious about the
>> content_length values that could be added to the newly unsigned int
>> counter variable.
> 
> hmm, in tunnel.cc, all the sizes are unsigned, and the only place where
> content_length hits the newly unsigned expectedLength is protected by a
> test that content_length is positive or 0. Maybe you saw something else
> but otherwise I feel the change is safe.
> 
> Best regards,
>  Aymeric
> 


Applied to Squid-4 as rev.14325.

Amos



More information about the squid-dev mailing list