[squid-dev] [PATCH] keep track of the size of uploads done with CONNECT

Aymeric Vincent aymericvincent at free.fr
Tue Sep 22 17:18:24 UTC 2015


Hi,

Amos Jeffries <squid3 at treenet.co.nz> writes:

> This looks okay in itself. I am just a little suspicious about the
> content_length values that could be added to the newly unsigned int
> counter variable.

hmm, in tunnel.cc, all the sizes are unsigned, and the only place where
content_length hits the newly unsigned expectedLength is protected by a
test that content_length is positive or 0. Maybe you saw something else
but otherwise I feel the change is safe.

Best regards,
 Aymeric


More information about the squid-dev mailing list