[squid-dev] [PATCH] Coverity(-inspired) fixes part four, HttpHeader refactor

Kinkie gkinkie at gmail.com
Fri Aug 21 16:47:24 UTC 2015


This is in fact what I have tried to - sometimes not to the letter,
unfortunately, and I'm sorry for that.

On Fri, Aug 21, 2015 at 6:46 PM, Alex Rousskov <
rousskov at measurement-factory.com> wrote:

> On 08/21/2015 04:37 AM, Kinkie wrote:
> > I changed that only when something in the vicinity changed so not to
> > make the patch any more enormous. I can blanket change if that's
> preferred.
>
> IMO, the rule ought to be very simple and precise: Rename NULL if and
> only if renaming does not add any new lines to the diff.
>
> Same for removing HERE. Why it is so hard to follow that rule and avoid
> unnecessary changes is really beyond me.
>
> Alex.
>
>


-- 
    Francesco
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20150821/a0a116d6/attachment.html>


More information about the squid-dev mailing list