[squid-dev] [PATCH] Coverity(-inspired) fixes part four, HttpHeader refactor

Alex Rousskov rousskov at measurement-factory.com
Fri Aug 21 16:46:04 UTC 2015


On 08/21/2015 04:37 AM, Kinkie wrote:
> I changed that only when something in the vicinity changed so not to
> make the patch any more enormous. I can blanket change if that's preferred.

IMO, the rule ought to be very simple and precise: Rename NULL if and
only if renaming does not add any new lines to the diff.

Same for removing HERE. Why it is so hard to follow that rule and avoid
unnecessary changes is really beyond me.

Alex.



More information about the squid-dev mailing list