[squid-dev] [PATCH] Collapse internal revalidation requests (SMP-unaware caches)

[Amos Jeffries]

On 21/07/2016 9:20 p.m., Eduard Bagdasaryan wrote:
> 2016-07-20 16:21 GMT+03:00 Amos Jeffries:
>> Couple of things:
>>
>> * some of the new methods need to be adjusted to follow the Squid coding
>> style. With return-type and opening '{' on different lines to the
>> name(params).
>>  - I noticed calcPublicKey and adjustVary in src/store.cc, there may be
>> others.
>>
>>
>> * the keyScope enum defined in src/store_key_md5.h is used in several
>> places with implicit boolean conversion.
>>  To ensure that works reliably across different compilers and
>> environments, the enum definition needs the first entry/value to be
>> explicitly defined with the "= 0" so the false case is identifiable.
> 
> 
>> 2016-07-20 19:04 GMT+03:00 Alex Rousskov:
>> On 07/17/2016 08:05 AM, Eduard Bagdasaryan wrote:
>> > +    /// whether this storage is capable of serving multiple workers
>> > +    virtual bool smpAware() const = 0;
>>
>> The description is correct, but let's also document that smpAware()ness
>> does not say anything about non-SMP support, in case somebody tries to
>> use this method to detect misconfiguration errors:
>>
>> /// whether this storage is capable of serving multiple workers;
>> /// a true result does not imply [lack of] non-SMP support because
>> /// [only] some SMP-aware storages also support non-SMP configs
>> virtual bool smpAware() const = 0;
> 
> 
> Updated patches with these fixes.
> 

Applied to trunk as rev.14755

Amos