[squid-dev] [PATCH] Collapse internal revalidation requests (SMP-unaware caches)

[Eduard Bagdasaryan]

2016-07-20 16:21 GMT+03:00 Amos Jeffries <squid3 at treenet.co.nz>:
 > Couple of things:
 >
 > * some of the new methods need to be adjusted to follow the Squid coding
 > style. With return-type and opening '{' on different lines to the
 > name(params).
 >  - I noticed calcPublicKey and adjustVary in src/store.cc, there may be
 > others.
 >
 >
 > * the keyScope enum defined in src/store_key_md5.h is used in several
 > places with implicit boolean conversion.
 >  To ensure that works reliably across different compilers and
 > environments, the enum definition needs the first entry/value to be
 > explicitly defined with the "= 0" so the false case is identifiable.


 > 2016-07-20 19:04 GMT+03:00 Alex Rousskov 
<rousskov at measurement-factory.com>:
 > On 07/17/2016 08:05 AM, Eduard Bagdasaryan wrote:
 > > +    /// whether this storage is capable of serving multiple workers
 > > +    virtual bool smpAware() const = 0;
 >
 > The description is correct, but let's also document that smpAware()ness
 > does not say anything about non-SMP support, in case somebody tries to
 > use this method to detect misconfiguration errors:
 >
 > /// whether this storage is capable of serving multiple workers;
 > /// a true result does not imply [lack of] non-SMP support because
 > /// [only] some SMP-aware storages also support non-SMP configs
 > virtual bool smpAware() const = 0;


Updated patches with these fixes.


Eduard.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SQUID-197-collapse-revalidation-requests-3.5-t5.patch
Type: text/x-patch
Size: 121618 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160721/614a1d71/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SQUID-197-collapse-revalidation-requests-t12.patch
Type: text/x-patch
Size: 104079 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160721/614a1d71/attachment-0003.bin>