[squid-dev] [PATCH] Older response must not update

Eduard Bagdasaryan eduard.bagdasaryan at measurement-factory.com
Thu Aug 25 14:18:28 UTC 2016

2016-08-24 18:20 GMT+03:00 Amos Jeffries <squid3 at treenet.co.nz>:

 > in src/LogTags.cc:
 > * instead of adding new enum entry please extend LogTags with a new bool
 > flag and the c_str() to append the "IGNORED" when that flag is true.
 >  - TCP_REFRESH should be set when refresh was started.
 >  - whoever merges this patch will also need to update the wiki
 > SquidFaq/SquidLogs page to document what "IGNORED" means.

Added a new LogTags::ignored for this. I wonder whether the
LogTags assignment operator should copy this member too.

 > in src/HttpReply.cc:
 > * please use Squid syntax.
 >   -  return type on separate line above the method/function name.
 > in src/HttpReply.h:
 > * please use doxygen syntax "\returns" instead of "returns" in the
 > comment text.
 > in src/client_side_reply.cc:
 > * please remove the "handleIMSReply: " bit from touched debugs messages.

2016-08-24 22:05 GMT+03:00 Alex Rousskov <rousskov at measurement-factory.com>:

 > If Eduard does that, he should remove that bit from all related debugs
 > messages to keep them all consistent IMO.

Addressed these comments and updated the patch.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SQUID-174-older-response-must-not-update-t6.patch
Type: text/x-patch
Size: 26108 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160825/9667ae7a/attachment.bin>

More information about the squid-dev mailing list