[squid-dev] [PATCH] Older response must not update
rousskov at measurement-factory.com
Wed Aug 24 19:05:49 UTC 2016
On 08/24/2016 09:20 AM, Amos Jeffries wrote:
> in src/HttpReply.h:
> * please use doxygen syntax "\returns" instead of "returns" in the
> comment text.
No objection, but please note that the "returns..." phrase in isolation
does not fully describe what the method returns in this case. Only the
method description taken as a whole describes that.
> in src/client_side_reply.cc:
> * please remove the "handleIMSReply: " bit from touched debugs messages.
If Eduard does that, he should remove that bit from all related debugs
messages to keep them all consistent IMO.
More information about the squid-dev