[squid-users] Squid typo fixes for 4.12

[Amos Jeffries]

On 30/06/20 7:38 pm, L.P.H. van Belle wrote:
> Hai, 
>  
> Sorry for not pushing this through git.
> If you want some typo fixed, here you go.
> 
> 
> Fixed typo's found by Lintian on Debian Buster.
> --- a/src/ssl/crtd_message.cc
> +++ b/src/ssl/crtd_message.cc
> @@ -206,7 +206,7 @@
>      i = map.find(Ssl::CrtdMessage::param_Sign);
>      if (i != map.end()) {
>          if ((certProperties.signAlgorithm = Ssl::certSignAlgorithmId(i->second.c_str())) == Ssl::algSignEnd) {
> -            error = "Wrong signing algoritm: ";
> +            error = "Wrong signing algorithm: ";
>              error += i->second;
>              return false;
>          }
> --- a/CREDITS
> +++ b/CREDITS
> @@ -1631,7 +1631,7 @@
>   * (C) 2000 Antonino Iannella, Stellar-X Pty Ltd
>   * Released under GPL, see COPYING-2.0 for details.
> 
> - * Released under GNU Public License
> + * Released under GNU General Public License
>   *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by


FTR; License text is not subject to trivial re-writing. The third-party
code being used by Squid was supplied with that particular wording for
their license description and we must not change it without permission.
("GNU Public License" was an actual license back in the dawn of time).

In absence of contact with the copyright holder we may only replace the
code wholesale with an updated version from that author where they
provide a different license text, or a cleanroom implementation from
someone else.


The rest of the patch is fine. Though please be aware that some of the
error messages have translation texts which will be prevented from
appearing when changed.


Amos