[squid-users] Squid 3.5.16 and vary loop objects (bug ?)

[Ralf Hildebrandt]

* Amos Jeffries <squid3 at treenet.co.nz>:

> So lets try this again...
> 
> Can somebody check whether applying the attached patch _and_ clearing
> the cache does anything useful?
> (should apply with "patch -p0" to squid-3.5.16)

Will try, but then I'm on 4.0.8...
 
> If the answer is yes, then it can be used while I work on a better fix
> that wont need clearing the cache.
> 
> Amos
> 

> === modified file 'src/store_swapmeta.cc'
> --- src/store_swapmeta.cc	2016-04-01 06:15:31 +0000
> +++ src/store_swapmeta.cc	2016-04-06 12:03:43 +0000
> @@ -89,9 +89,7 @@
>      SBuf vary(e->mem_obj->vary_headers);
>  
>      if (!vary.isEmpty()) {
> -        // TODO: do we still need +1 here? StoreMetaVary::checkConsistency
> -        //       no longer relies on nul-termination, but other things might.
> -        t = StoreMeta::Factory(STORE_META_VARY_HEADERS, vary.length() + 1, vary.c_str());
> +        t = StoreMeta::Factory(STORE_META_VARY_HEADERS, vary.length(), vary.c_str());
>  
>          if (!t) {
>              storeSwapTLVFree(TLV);
> 

> _______________________________________________
> squid-users mailing list
> squid-users at lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-users

-- 
Ralf Hildebrandt                   Charite Universitätsmedizin Berlin
ralf.hildebrandt at charite.de        Campus Benjamin Franklin
http://www.charite.de              Hindenburgdamm 30, 12203 Berlin
Geschäftsbereich IT, Abt. Netzwerk fon: +49-30-450.570.155