[squid-users] squid-3.5.1 with perl-5.20

[Eray Aslan]

I have a user report that says ext_wbinfo_group_acl is not working with
perl-5.20:

Global symbol "$groupSID" requires explicit package name at
/usr/libexec/squid/ext_wbinfo_group_acl
in cache.log and these lines:
FATAL: The nt_group helpers are crashing too rapidly, need help!
Squid Cache (Version 3.5.1): Terminated abnormally.

Apparently, the following patch fixes the problem:

--- helpers/external_acl/wbinfo_group/ext_wbinfo_group_acl.pl.in.orig	2015-02-09 21:50:59.184021388 +0300
+++ helpers/external_acl/wbinfo_group/ext_wbinfo_group_acl.pl.in	2015-02-09 21:52:56.759492956 +0300
@@ -121,6 +121,11 @@
 #
 use vars qw/ %opt /;
 
+my $user;
+my $group;
+my @groups;
+my $ans;
+
 # Disable output buffering
 $|=1;
 
@@ -132,7 +137,11 @@
 # Check if a user belongs to a group
 #
 sub check {
-        local($user, $group) = @_;
+	my $groupSID;
+	my $groupGID;
+	my @tmpuser;
+
+        our($user, $group) = @_;
 	if ($opt{K} && ($user =~ m/\@/)) {
 		@tmpuser = split(/\@/, $user);
 		$user = "$tmpuser[1]\\$tmpuser[0]";

Details at:
https://bugs.gentoo.org/show_bug.cgi?id=539500

-- 
Eray