[squid-dev] Introducing myself to Squid Devs

[Alex Rousskov]

On 2024-10-25 15:24, Shailesh Vashishth wrote:

> I would like to take up another Todo item that is listed here -- 
> https://github.com/measurement-factory/squid-notes/blob/start/todos.md 

> I would like to pick this item : I think this requires very small 
> change, where we just print name_len on the stdout using the custom 
> function for printing debug logs.

I assume you are suggesting to add name_len reporting to existing 
debugs() by including debugs() parameters similar to these:

     debugs(... "name_len=" << name_len ...);

Doing the above will not be the right way to address that TODO IMO. A 
better way is hinted at by XXX comment itself (still quoted further 
below) and detailed a bit more in the TODO item itself. You will need to 
modify Squid class Raw, so that the resulting debugs() code could look 
something like this:

     debugs(... Raw("field", field_start, name_len).upTo(100) ...);

HTH,

Alex.


>   * Address the following TODO by adding any using Raw::upto(n) which
>     will limit the size value of passed to PrintHex() and write() inside
>     Raw::print(). That value is currently size_.
> 
>     if (name_len > 65534) {
>     /* String must be LESS THAN 64K and it adds a terminating NULL */
>     // TODO: update this to show proper name_len in Raw markup, but not
>     print all that
>     debugs(55, 2, "ignoring huge header field (" << Raw("field_start",
>     field_start, 100) << "...)");
> 
> 
> 
> My current PR (_https://github.com/squid-cache/squid/pull/1921 
> <https://github.com/squid-cache/squid/pull/1921>_) has succeeded all 
> Pipeline stages, only your approval is remaining.
> 
> Regards
> Shailesh
> 
> On Wed, Oct 23, 2024 at 12:30 AM Shailesh Vashishth 
> <shavashishth at gmail.com <mailto:shavashishth at gmail.com>> wrote:
> 
>     Hi
>     I have made a change to a math expression in store_client.cc and
>     raised the following pull request.
> 
>     if (curlen > expectlen*(Config.quickAbort.pct/100.0)) {
>     debugs(90, 3, "quick-abort? NO past point of no return");
>     return false;
>     }
> 
>     I have also ran the test-build.sh (suggested in Submissions
>     Checklist) and it passed all test cases.
> 
>     Please review the following pull request -
>     https://github.com/squid-cache/squid/pull/1921
>     <https://github.com/squid-cache/squid/pull/1921>
> 
>     Regards
>     Shailesh
> 
>     On Sat, Oct 5, 2024 at 1:27 PM Shailesh Vashishth
>     <shavashishth at gmail.com <mailto:shavashishth at gmail.com>> wrote:
> 
>         Hi Alex,
>         I read your hint and made changes accordingly, it didn't go to
>         spam this time. I was going through the Squid Docs, on how to
>         submit PR and do those pre-merge self tests (Submission Checklist).
> 
>         I will do the steps given in the Submission Checklist and submit
>         a PR in a day or two.
> 
>         Thank you for helping me with getting started and joining the
>         project.
> 
>         Regards
>         Shailesh
> 
> 
>         On Fri, Oct 4, 2024 at 6:53 PM Alex Rousskov
>         <rousskov at measurement-factory.com
>         <mailto:rousskov at measurement-factory.com>> wrote:
> 
>             On 2024-10-03 15:49, Shailesh Vashishth wrote:
> 
>              > I would like to contribute to the Squid Project and I
>             have picked one
>              > small task out of the ToDos  for myself.
> 
> 
>             Hello Shailesh,
> 
>                   Welcome to the Project and good luck with your first
>             task! If you
>             need any help, please do not hesitate to ask on this mailing
>             list or to
>             post a draft pull request for discussion on GitHub:
>             https://wiki.squid-cache.org/MergeProcedure
>             <https://wiki.squid-cache.org/MergeProcedure>
> 
>             BTW, I have also emailed you a few hints regarding the code
>             below when
>             you asked about it privately -- check your spam folder if
>             you have not
>             seen my response dated September 30, 2024...
> 
> 
>             Cheers,
> 
>             Alex.
> 
> 
>              >     *// XXX: This is absurd! TODO: For positives,
>             "a/(b/c) > d" is "a*c
>              >      > b*d".
>              >     **if (expectlen < 100) {
>              >     **   debugs(90, 3, "quick-abort? NO avoid FPE");
>              >     **   return false;
>              >     **}*
>              >
>              >     */_if ((curlen / (expectlen / 100)) >
>             (Config.quickAbort.pct)) {
>              >     _/**   debugs(90, 3, "quick-abort? NO past point of
>             no return");
>              >     **   return false;
>              >     **}*
> 
> 
> 
> 
> 
> 
> _______________________________________________
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
> https://lists.squid-cache.org/listinfo/squid-dev