[squid-dev] Introducing myself to Squid Devs

[Shailesh Vashishth]

Hi
I have made a change to a math expression in store_client.cc and raised the
following pull request.

if (curlen > expectlen*(Config.quickAbort.pct/100.0)) {
debugs(90, 3, "quick-abort? NO past point of no return");
return false;
}

I have also ran the test-build.sh (suggested in Submissions Checklist) and
it passed all test cases.

Please review the following pull request -
https://github.com/squid-cache/squid/pull/1921

Regards
Shailesh

On Sat, Oct 5, 2024 at 1:27 PM Shailesh Vashishth <shavashishth at gmail.com>
wrote:

> Hi Alex,
> I read your hint and made changes accordingly, it didn't go to spam this
> time. I was going through the Squid Docs, on how to submit PR and do those
> pre-merge self tests (Submission Checklist).
>
> I will do the steps given in the Submission Checklist and submit a PR in a
> day or two.
>
> Thank you for helping me with getting started and joining the project.
>
> Regards
> Shailesh
>
>
> On Fri, Oct 4, 2024 at 6:53 PM Alex Rousskov <
> rousskov at measurement-factory.com> wrote:
>
>> On 2024-10-03 15:49, Shailesh Vashishth wrote:
>>
>> > I would like to contribute to the Squid Project and I have picked one
>> > small task out of the ToDos  for myself.
>>
>>
>> Hello Shailesh,
>>
>>      Welcome to the Project and good luck with your first task! If you
>> need any help, please do not hesitate to ask on this mailing list or to
>> post a draft pull request for discussion on GitHub:
>> https://wiki.squid-cache.org/MergeProcedure
>>
>> BTW, I have also emailed you a few hints regarding the code below when
>> you asked about it privately -- check your spam folder if you have not
>> seen my response dated September 30, 2024...
>>
>>
>> Cheers,
>>
>> Alex.
>>
>>
>> >     *// XXX: This is absurd! TODO: For positives, "a/(b/c) > d" is "a*c
>> >      > b*d".
>> >     **if (expectlen < 100) {
>> >     **   debugs(90, 3, "quick-abort? NO avoid FPE");
>> >     **   return false;
>> >     **}*
>> >
>> >     */_if ((curlen / (expectlen / 100)) > (Config.quickAbort.pct)) {
>> >     _/**   debugs(90, 3, "quick-abort? NO past point of no return");
>> >     **   return false;
>> >     **}*
>>
>>
>>
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20241023/dc2b54f1/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_build_output
Type: application/octet-stream
Size: 10438 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20241023/dc2b54f1/attachment.obj>