[squid-dev] Efficient FD annotations

[Amos Jeffries]

On 7/01/20 4:28 am, Alex Rousskov wrote:
> For the record: The ideas below are superseded by the concept of the
> code context introduced in commit ccfbe8f, including the
> fde::codeContext field. --Alex
> 

If you want to go that way (replace fde:note with fde:codeContext) we
are going to have to do a security audit on the values displayed by the
CodeContext objects. That is due to how the fde::note are sent over the
public network in clear-text transactions for mgr:filedescriptors report.


In regards to PR 70;
  Most of the notes which are dynamically created are coming from the
URL field of HttpRequest which has become an SBuf while this PR was on hold.
 So the performance hit is much reduced from what worried you in the
earlier review. In fact we are about to gain the removal of a c_str() in
the common path and a xstrndup() on all SMP worker shared FDs.


Amos