[squid-dev] [PATCH] check parameters for negotiate_wrapper

[Alex Rousskov]

On 05/14/2017 11:40 AM, Amos Jeffries wrote:
> There has been some confusion about what --helper-protocol parameters
> the Samba ntlm_auth helper needs when used with negotiate_wrapper helper.
> 
> This adds checks and warnings to the ensure the protocol used matches
> the --ntlm or --kerberos section.

I do not know enough about this area to properly review the patch so
please do not wait for my review.

FWIW, it looks like the changed code is still using strncasecmp() in
several places where strcasecmp() or even strcmp() should be used instead.


Thank you,

Alex.