[squid-dev] [PATCH] Digest Auth support for LDAP HA1 attribute without realm

[Amos Jeffries]

On 23/06/17 03:31, FUSTE Emmanuel wrote:
> Le 09/02/2017 à 17:43, Amos Jeffries a écrit :
>> On 7/02/2017 10:33 p.m., FUSTE Emmanuel wrote:
>>> New patch attached.
>>> - Empty realm parameter is treated as no realm parameter supplied.
>>> - realm parameter is mandatory if empty delimiter is supplied
>>> - -f vs -F typo corrected in the help text
>>> Tested in real conditions.
>>>
>> Thanks. I have applied to v5 as rev.15039 with some small adjustments:
>>
>> * more spelling fixes in the help text
>>
>> * rearranged the complex if condition to make it more clear exactly what
>> the two supported cases are.
>>
>> Amos
>>
> Hello,
> 
> Was using my version of the patch until now.
> I tested rev.15039 commit on 3.5 on my environment today and it was not
> working.
> 
> corrected by changing the second lookup bool condition  from
> (*frealm && strcmp(requestData->realm, frealm) != 0);
> by
> (*frealm && (strcmp(requestData->realm, frealm) == 0))
> 
> Emmanuel.
> 
> 

Ouch. Thanks. Applied that fix.


Amos