[squid-dev] [PATCH] Reduce "!Comm::MonitorsRead(serverConnection->fd)" assertions.

[Alex Rousskov]

On 06/21/2017 05:40 AM, Christos Tsantilas wrote:

> Replaced primary ConnStateData::pinConnection() calls with a pair of
> pinBusyConnection() and notePinnedConnectionBecameIdle() calls,
> depending on the pinned connection state ("busy" or "idle").
> 
> Removed pinConnection() parameters that were not longer used or could be
> computed from the remaining parameters.

I suggest the following one or two polishing touches:

1. Merge pinConnection() and pinNewConnection() by returning from the
method if there is nothing to do, with a debugs() line printing
pinServer. The merged method would be called pinConnection(), of course.

2. *If* the request object is actually always there, then change the
pinConnection() parameter to an Http::Request reference (and change
callers to dereference their request pointers).


The above polishing touches and Amos' "do not name unused pic parameter"
request do not require another round of reviews IMO. However, more
discussions or even changes may be necessary to resolve other Amos'
requests.


Thank you,

Alex.