[squid-dev] [BUG] Incorrect "FS Block Size" printed by cachemgr.cgi for the Rock store

[Alex Rousskov]

On 06/08/2017 09:06 PM, Stéphane Ouellette wrote:

>    while I was testing the use of the rock store on a ZFS pool using
> file system block sizes of 4K, 8K and 16K, I noticed that cachemgr.cgi
> always printed "FS Block Size = 1024" in all cases.
> 
>    I tracked down the issue by comparing Rock::SwapDir::init() to
> Fs::Ufs::UFSSwapDir::init(). I discovered a missing instruction.
> Following is the proposed patch that applies to Squid 3.5.26.

Thank you for investigating this! I agree that there is a bug, but I
think the underlying issue is actually located elsewhere. AFAICT, Rock
does not use the file system block or fragment size. Thus, the correct
fix is not to add unused code to Rock, but to move this UFS-only
feature, including sizeInBlocks() to Fs::Ufs classes.

Can you make the corresponding patch please?

Alex.