[squid-dev] [PATCH] Do not die silently when dying via std::terminate()

[Alex Rousskov]

On 06/01/2017 06:38 PM, Alex Rousskov wrote:
> On 05/17/2017 06:20 PM, Alex Rousskov wrote:
>> Hello,
>>
>>     While triaging a silent crash of a production Squid, I realized that
>> our death reporting code has a serious (and recently grown) hole. The
>> attached patch closes it. This reporting-only patch does not fix any
>> crashes. There are more technical details in the preamble.
>>
>> Researching this problem gave me an idea on how we can preserve Squid
>> stack when dying from unhandled runtime exceptions. This patch does not
>> implement that idea but adds a corresponding XXX and TODO comments.
>>
>> This patch changes the same SquidMainSafe() code as the pending atomic
>> PID patch does. While the changes conflict at the patch level, they are
>> fully compatible at the "logic level". The conflict is easy to resolve.

> I saw no reviews and will commit these changes soon unless there are
> last-minute objections.
 Committed to v5 (r15171).

Alex.