[squid-dev] [PATCH] Memory overlap Valgrind-reported errors

[Eduard Bagdasaryan]

Thank you.
Also I believe the same patch could be applied to v4 and v3.5
(with a little adjustment). Are you planning to do this?


Eduard.

On 15.01.2017 20:37, Amos Jeffries wrote:
> On 16/01/2017 5:15 a.m., Eduard Bagdasaryan wrote:
>> Fixed "Source and destination overlap in memcpy" Valgrind errors.
>>
>> Before this patch, source and destination arguments in
>> log_quoted_string() could point to the same static memory area, causing
>> multiple Valgrind-reported errors. Fixed by creating another buffer for
>> storing the quoted-processed output string. The buffer size should be
>> enough to hold all processed escape sequences.
>>
> Ouch. Thanks for finding this.
>
> +1 and Applied to v5 as rev.15010
>
> Amos
>
> _______________________________________________
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev