[squid-dev] [PATCH] remove USE_CHUNKEDMEMPOOLS

[Amos Jeffries]

On 12/01/2017 4:46 a.m., Alex Rousskov wrote:
> On 01/11/2017 08:29 AM, Amos Jeffries wrote:
>> On 1/01/2017 6:37 p.m., Amos Jeffries wrote:
>>> The USE_CHUNKEDMEMPOOLS build-time setting is not very useful and adds
>>> extra complexity to the build system. Even when set it does not always
>>> enable chunked pools. The environment variable MEMPOOLS can easily be
>>> used to enable or disable chunked pools as needed.
>>>
>>
>> If there are no objections I would like to commit this shortly.
> 
> None from me, but I did not study the patch closely. FWIW, adjusting the
> commit message to explicitly say whether this change alters any
> defaults, may help those assessing the change impact on their setups.
> 
> 
> Thank you,
> 
> Alex.
> 

It does not change any defaults or behaviour for the vast majority of
Squid installs. But anyone who was building custom with
CXXFLAGS="-DUSE_CHUNKEDMEMPOOLS=1" will now have to use the run-time
environment variable.

Amos