[squid-dev] Dereferencing null headClone

[Alex Rousskov]

On 02/16/2017 06:13 PM, Amos Jeffries wrote:
> On 17/02/2017 6:53 a.m., Alex Rousskov wrote:
>> On 02/16/2017 10:34 AM, scan-admin at coverity.com wrote:
>>
>>> 1607         Must(headClone != NULL);
>>>>>>     CID 1400650:  Null pointer dereferences  (FORWARD_NULL)
>>>>>>     Passing null pointer "headClone" to "inheritProperties", which dereferences it.
>>> 1608         headClone->inheritProperties(head);
>>
>> Can somebody please configure Coverity so that it treats Must(x) as
>> assert(x) as far as truthfulness of x after the check is concerned?
>>
> 
> Done, I think.


Thank you. And self_destruct() as well please:

> *** CID 1401397:  API usage errors  (INVALIDATE_ITERATOR)
> /src/MessageDelayPools.cc: 150 in MessageDelayConfig::parseResponseDelayPool()()
> 144             }
> 145             auto it = params.find(SBuf(key));
> 146             if (it == params.end()) {
> 147                 debugs(3, DBG_CRITICAL, "FATAL: response_delay_pool unknown option '" << key << "'");
> 148                 self_destruct();
> 149             }
>>>>     CID 1401397:  API usage errors  (INVALIDATE_ITERATOR)
>>>>     Dereferencing iterator "it" though it is already past the end of its container.
> 150             it->second = (it->first == initialBucketPercent) ? xatos(value) : xatoll(value, 10);
> 151         }
> 152     

Alex.