[squid-dev] [PATCH] VIA creation code duplication

[Eduard Bagdasaryan]

I see that String::append asserts when String is unable to "grow":
String has hardcoded ~64Kb limit for that. It is hardly possible since
most of web servers have header length limit less than this value.
Theoretically a buggy upstream server could generate such huge Via.
However any other header may assert as well, since HttpHeaderEntry
stores its value in String. Why do you think we should care only about
Via header overflow?


Eduard.


On 13.02.2017 00:56, Amos Jeffries wrote:
> Thank you. But if we are going to keep the copy+append behaviour we have
> to consider the assertion in String::append which goes off if the client
> has supplied a large header already. We need to either assemble in the
> SBuf, or to check the strVia length before appending the new parts.
>
> Amos
>
> _______________________________________________
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev