[squid-dev] [PATCH] initial GnuTLS support for encrypted server connections

[Alex Rousskov]

On 02/01/2017 01:42 PM, Christos Tsantilas wrote:
> must take in account that some openSSL calls
> returns locket objects, and some other unlocked objects.

Does the patch start using shared pointers for any objects in the
second, "returned unlocked" category? AFAICT, only the SSL connection
object (shared_ptr<SSL>) is currently affected. That object is always
given to Squid locked by OpenSSL, right?

We would have to remember to ask ourselves these questions for every new
OpenSSL-lockable type that we start using inside a shared_ptr, of
course, but if OpenSSL always returns locked SSL objects, those should
be "safe to share" AFAICT.

Thank you,

Alex.