[squid-dev] [PATCH] cleanup external_acl_type cache

[Adam Majer]

On 04/12/2017 04:27 PM, Alex Rousskov wrote:
>> If you need an intrusive list container for performance reasons, please
>> consider using Boost.Intrusive instead of rolling your own.
>>
>>     http://www.boost.org/doc/libs/1_63_0/doc/html/intrusive/list.html
> 
> The idea of using Boost for Squid has been discussed and, IIRC, rejected
> (for the time being): We have more than enough troubles coping with
> standard C++ features. Dealing with another major library (that should
> penetrate a lot of Squid code to gain the most benefits) without an
> in-house Boost expert is a bad idea, especially when the Squid code
> itself is still too messy to allow for neat/safe conversions like that.
> C++11 reduces the pressure to use Boost by providing some of the Boost
> features.


Boost is not a library, per say. It's a collection of libraries. Using a
very small, header-only part to replace handrolled implementation is I
think a positive.

For most OS Boost is already shipped, but it certainly does introduce
its own problems. And since I have to deal and fix the "beautiful"
Boost.Build intricacies, it's not something you want to deal with often!

Sometimes these things fall into the "premature optimization" area,
especially for the reasons you've mentioned.

- Adam