[squid-dev] [PATCH] Bug 3819: "fd >= 0" assertion in file_write() during reconfiguration

[Alex Rousskov]

Hello,

    The attached trunk patch fixes bug 3819 in our tests.

Please note that the underlying problem may lead to other assertions,
including "NumberOfUFSDirs" in UFSSwapDir and "fd >= 0" in file_close().

Since trunk r9181.3.1, reconfiguration is done in at least two steps:
First, mainReconfigureStart() closes/cleans/disables all modules
supporting hot reconfiguration and then, at the end of the event loop
iteration, mainReconfigureFinish() opens/configures/enables them again.
UFS code hits assertions if it has to log entries or rebuild swap.state
between those two steps.  The patch disables or delays those activities
during reconfiguration.

The tiny assertion opportunity window hides these bugs from most proxies
that are not doing enough disk I/O or are not being reconfigured
frequently enough.


HTH,

Alex.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: SQUID-231-bug3819-fd-assert-reconf-t5.patch
Type: text/x-diff
Size: 17430 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160919/6c817d40/attachment.patch>