[squid-dev] [PATCH] Incorrect logging of request size

[Alex Rousskov]

On 09/12/2016 10:06 PM, Amos Jeffries wrote:
> Just the new cf.data.pre docs for icap_log contradicting itself:
> 
> "
>   http::>h	...
>       HTTP response headers in RESPMOD) ...
>       currently does not support logging of HTTP response headers in
> RESPMOD ...
> "
> 
> I think that should probably be saying it does not support HTTP
> *request* headers in RESPMOD.

I assume you are talking about this blob:

> http::>h 
> To-be-adapted HTTP message headers sent by Squid to
> the ICAP service (HTTP request headers in REQMOD; HTTP
> response headers in RESPMOD). Please note that Squid
> currently does not support logging of HTTP response
> headers in RESPMOD for this format code.

I will clarify that when committing:

http::>h   To-be-adapted HTTP message headers sent by Squid to the ICAP
service (i.e., HTTP request headers in REQMOD or HTTP response headers
in RESPMOD). However, Squid cannot currently log HTTP response headers
sent to the ICAP service (i.e., %http::>h will expand to "-" for RESPMOD
transactions).

Does that sound better?


If the above polished version does not clarify things enough, here is
what is going on:

* The logformat %code is for logging HTTP message headers sent by Squid
to the ICAP service. That will not change and is now properly
documented. What are those to-be-adapted HTTP headers? They are HTTP
request headers in REQMOD and HTTP response headers in RESPMOD. We did
not have to say that, but providing that detail is helpful IMO.

* However, currently, Squid cannot log HTTP response headers sent by
Squid to the ICAP service. The admin will always see "-" in that
specific case. Hopefully, that support will be added in the future. For
now, we just document the lack of support in that particular case.


Thank you,

Alex.