[squid-dev] [PATCH] Refactor wordlist to SBufList in acl/RegexData

Amos Jeffries squid3 at treenet.co.nz
Wed Oct 26 21:40:27 UTC 2016


On 27/10/2016 9:16 a.m., Kinkie wrote:
> Hi all,
>    the attached patch refactors the use of wordlist to SBufList in
> acl/RegexData.cc; the "test.txt" attachment shows the output of
> "./src/squid -X 2>&1 | grep 'RegexData' >/tmp/test_plan.txt" when
> applied to a default configuration file with these additions:
> acl t1 dstdom_regex pattern1 pattern2
> acl t2 dstdom_regex -i pattern3 pattern4
> acl t3 dstdom_regex +i pattern5 pattern6
> 

Audit:

* can you please take advantage of the change to get rid of the
"compileOptimisedREs: compileOptimisedREs:" in the logs

* please use emplace_back instead of sl.push_back(SBuf(clean));
 - line ~234


+1.

Amos



More information about the squid-dev mailing list