[squid-dev] [PATCH] Handling syntactically valid requests with higher-than-supported HTTP versions

[Amos Jeffries]

On 5/10/2016 2:34 a.m., Eduard Bagdasaryan wrote:
> 2016-09-26 1:23 GMT+03:00 Amos Jeffries <squid3 at treenet.co.nz>:
> 
>> Okay finally got to this. Sorry for the delay.
>>
>> I think what confused me was the handling of the !multiDigits cases.
>>
>> For the RequestParser::parseVersionField() the relevant bits are:
>>
>> If a version label matches the "HTTP/" 1*DIGIT "." 1*DIGIT pattern from
>> RFC 2616 it should not be handled as 0.9 syntax. All unacceptible
>> versions that begin with "HTTP/" should get a 505.
>>
>> To be compliant with RFC 7230:
>>
>> - versions 1.2 thru 1.9 accept and handle normally. That is a SHOULD
>> requirement in section 2.6 final paragraph (bottom of page 15).
>>
>> - other single-digit versions should get the 505 error.
>>
>> - versions with multiple digits should get the 505 error.
> 
> 
> Adjusted the code accordingly and reattached the patch and testing results.
> 
> 

Yay. All passing :-)

I think the comment should say " ('0.0') " rather than '(zero)'. On
first reading I thought it might lead to '1.0' being identified.

+1, and applied as trunk rev.14866 with that documentation tweak.

Amos