[squid-dev] [PATCH] adaptation_rep_header ACL

[Alex Rousskov]

On 05/17/2016 08:24 AM, Steve Hill wrote:

> This patch adds an adaptation_rep_header ACL type.  This works in the
> same way as the existing rep_header ACL, except rather than matching
> HTTP response headers, it matches ICAP response headers.  This allows
> ICAP servers to pass data in the ICAP response headers which Squid can
> then use in ACLs.

Squid uses the note ACL for the purpose of accessing adaptation
metadata. The note ACL does not support ICAP headers today, but it does
support eCAP and helper "headers". ICAP support is a desirable (and
requested) feature. Please refactor your code to work with the note ACL
instead.


> Small performance gotcha: This requires the adaptation history to be
> recorded.  Previously the adaptation history was only recorded when
> necessary, but this patch enables it all the time.

IMO, this should also be fixed before this enhancement is officially
accepted.


Thank you,

Alex.