[squid-dev] [PATCH] assertion failed: Write.cc:41: "!ccb->active()"

[Christos Tsantilas]

On 03/15/2016 07:28 PM, Christos Tsantilas wrote:
> I applied the t4 patch to trunk as r14592

The t4 patch applied to squid-3.5  as r14001


>
> I am attaching the t4 patch for squid-3.5.
> I believe that we should apply this patch for this major reasons:
>    - The (statefull) FTP protocol requires good coordination between
> client-side and server side. The pinned connections is one mechanism
> which helps, but this is not enough. The stopWaiting/startWaiting adds
> one more mechanism. Will help us to solve more problems in the future.
>
>    - The t4 patch also solves one more bug: In the case the FTP server
> respond with an error status after the download is finished, squid will
> return wrong status code to the user (success). Fixing this bug is
> possible because of the new mechanism.
>
> Christos
>
>
> On 03/15/2016 01:01 AM, Amos Jeffries wrote:
>> On 15/03/2016 10:41 a.m., Alex Rousskov wrote:
>>> On 03/10/2016 02:35 PM, Alex Rousskov wrote:
>>>> Amos, do you want us to port take2 to v3.5? The take1 patch for v3.5 is
>>>> enough to fix the known assertion. Take2 fixes that assertion as well,
>>>> but it is bigger because it also fixes design problems that may lead to
>>>> other bugs in v3.5. Which one do you want in v3.5?
>>>
>>>
>>> Amos, that question still stands: What do you want to see in v3.5? The
>>> simple take1 patch that only addresses a specific assertion failure OR
>>> the ported take4+ patch that attempts to fix the general flaw via the
>>> new startWaitingForOrigin()/stopWaitingForOrigin() mechanism?
>>>
>>
>> I dont have a preference for either one.
>>
>> Amos
>