[squid-dev] [PATCH] implement RFC3986

[Kinkie]

> I do not think so. The crux of the issue is that you are defending a
> medium-size template function as a necessary and small evil, while I am
> attacking the principle or direction of accommodating helper needs by
> making Squid code worse.

Hi,
  the attached patch is a modification of what was currently shared,
de-templatized.
It relies on SBuf and provides a convenient std::string-based wrapper,
like you suggest.

>> In order to clarify, when I talk about couplign I mean link-time
>> coupling. This can be directly understood from the list of objects
>> needed for testSBuf: between headers, objects and stubs that's about
>> 30 files (on top of the testSBuf files themselves).
>
> If testSBuf has 30 dependencies, then I doubt testSBuf is a good example
> of how things should be done. Overall, if we want helpers to use Squid
> code, SBuf can be a part of the convenience library that can be linked
> with helpers without 30 "extra" or "stub" files. The number of files in
> that convenience library is pretty much irrelevant.

The introduction of libsbuf that has happened in the meanwhile causes
less dependency issues: it now only requires libsbuf, libmem, libbase,
libmisccontainers and libmiscutil, as _LDADD instead of _SOURCE files.
I'll work on removing the dependencies from misccontainers which is
required for trie by seeing if a std:: container behaves at least
comparably well for mempools.

-- 
    Francesco
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rfc3986.bundle
Type: application/octet-stream
Size: 33698 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160315/723a9194/attachment-0001.obj>