[squid-dev] [PATCH] g++ -Woverloaded-virtual

[Alex Rousskov]

On 03/12/2016 08:10 PM, Amos Jeffries wrote:
> On 12/03/2016 7:41 p.m., Alex Rousskov wrote:
>> Disclaimer: The Ftp::Relay::failed() fix is correct from removing the
>> warning point of view, but I have not checked whether the patched code
>> handles non-nil ftpErr correctly. AFAICT, this method is never called
>> with non-nil ftpErr today, but that may change.


> Checked. It does well enough that this is not adding any new bugs.
> Though some of the existing bugs might be tracked back to this call
> sequence not happening properly as-is.


> +!.

Thank you for checking! Committed as trunk r14590.

Alex.