[squid-dev] [PATCH] Ensure any previous value in lastAclData is free'd

[Nathan Hoad]

Sure, that seems straightforward enough. Attached is a patch that
migrates lastAclData to an SBuf.

Thank you,

Nathan.

On 11 March 2016 at 14:38, Amos Jeffries <squid3 at treenet.co.nz> wrote:
> On 11/03/2016 11:56 a.m., Nathan Hoad wrote:
>> Hello,
>>
>> Attached is a patch that ensures lastAclData doesn't leak any data,
>> exactly the same as lastAclName.
>>
>> In my testing, this wasn't leaking very much memory, but a leak regardless.
>>
>
> +1.
>
> Since the 'sb' variable it's being set from is an SBuf, and the format
> codes can now handle SBuf too - would you mind taking a stab at making
> lastAclData itself an SBuf?
>  That should get rid of some data-copy cycles and handle any related
> leaks hiding elsewhere.
>
> (just a request, if not that is fine and this can go in instead).
>
> Amos
>
> _______________________________________________
> squid-dev mailing list
> squid-dev at lists.squid-cache.org
> http://lists.squid-cache.org/listinfo/squid-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: migrate-lastAclData-to-SBuf.patch
Type: text/x-patch
Size: 1732 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160311/86611f65/attachment.bin>