[squid-dev] [PATCH] LockingPointer API update

[Alex Rousskov]

On 06/22/2016 08:31 AM, Christos Tsantilas wrote:
> On 06/22/2016 04:02 AM, Alex Rousskov wrote:
>> I have attached a list of relevant trunk calls. It may be incomplete.
>>
> I run over the list to check for problems.
> Also I checked the resetAndLock calls, looks ok.

Thank you!


> However the true is that the reset/resetAndLock scheme for
> lockingPointer is confusing.

Agreed. AFAICT, the primary source of that confusion is inconsistencies
in OpenSSL locking patterns. We can reduce that confusion by providing
resetWithoutLocking/resetAndLock pair instead of reset/resetAndLock.

If we really want to remove confusion, we would have to provide C++
wrappers for all relevant OpenSSL objects and hide locking inside our
wrapping code instead of requiring innocent _callers_ to worry about it.
I think doing so would be worthwhile in general, but it is a large
polishing project that we may not be able to finish soon because of the
more important projects standing in the way.

Alex.