[squid-dev] [PATCH] avoid flooding cache.log with "uninitialized value" messages from ext_wbinfo_group_acl helper script

[Amos Jeffries]

On 22/06/2016 7:22 p.m., Vieri wrote:
> Hi,
>
> With default debug_options too many "uninitialized value" messages in
/var/log/squid/cache.log;
> Use of uninitialized value $ans in concatenation (.) or string at
/usr/libexec/squid/ext_wbinfo_group_acl line 204, <STDIN> line 44.
> Use of uninitialized value $ans in concatenation (.) or string at
/usr/libexec/squid/ext_wbinfo_group_acl line 205, <STDIN> line 44.
>
> Minor issue fixed with this patch.

Thank you.

I was just double-checking this before applying and it looks to me like
$ans should never be unset in a properly configured group helper.

What does your squid.conf contain for this helper?
 (both the external_acl_type and the "acl ... external" lines using it
please)

And what does the debug output the helper injects into the log along
with those perl warnings look like?
 (should be something like "Sending ... to Squid".)


I'm asking because an empty line "\n" is not a valid response from an
external ACL helper. What the $ans needs to be initialized to depends on
whether it is a misconfiguration or something else resulting in the perl
warning.

PS. sorry for not noticing this earlier when you wrote to squid-users.

Amos