[squid-dev] r14692 broke ./configure

[Amos Jeffries]

On 10/06/2016 12:31 p.m., Alex Rousskov wrote:
> Hello,
> 
>     When running ./configure, I am getting the following error:
> 
>> ./configure: line 33410: 0: command not found
> 

That line number is in the middle of a long comment for my current trunk
./configure. Can you provide the line(s) where it occurs in yours?

And what option set exactly triggers this?

And what system shell is being used?

> 
> This problem was probably introduced by the following change:
> 
>> revno: 14692
>> branch nick: trunk
>> timestamp: Mon 2016-05-30 13:55:32 +1200
>> message:
>>   Deprecating SMB LanMan helpers
> ...
>> +AM_CONDITIONAL(ENABLE_SMBLIB, $require_smblib)
> 
> 
> AFAICT, AM_CONDITIONAL() needs a condition, not a variable:
> 
>> $ fgrep AM_CONDITIONAL configure.ac 
>> AM_CONDITIONAL(ENABLE_POD2MAN_DOC, test "x${ac_cv_path_POD2MAN}" != "x$FALSE")
>> AM_CONDITIONAL(ENABLE_RELEASE_DOCS, test "x${ac_cv_path_LINUXDOC}" != "x$FALSE")
>> AM_CONDITIONAL(ENABLE_LOADABLE_MODULES, test "x${enable_loadable_modules:=yes}" = "xyes")
>> AM_CONDITIONAL(ENABLE_WIN32SPECIFIC,[test "x$squid_host_os" = "xmingw"])
>> AM_CONDITIONAL(ENABLE_WIN32_IPC,[test "x$squid_host_os" = "xmingw"])
> ...
> 

It expands to the shell script:

  require_smblib=0
  ...
  if blah ...
    require_smblib=`test "x$BUILD_HELPER" = "xSMB_LM"`
  fi
  ...
  if $require_smblib; then
   ...
  fi


Which should work unless your shell has some weird if-condition or
sub-shell expansion behaviour going on.

Looking into an alternative now.


Amos