[squid-dev] [PATCH] Do not make bogus recvmsg calls

[Alex Rousskov]

Hello,

    The attached simple patch prevents bogus recvmsg(2) calls when
closing file descriptors. Please see the patch preamble for details.

A cleaner way to handle this problem may be to introduce a new
FD_FLUSH_METHOD() API that would do nothing for UDS (and possibly BIO
SSL?) sockets. However, a whole new API feels like a too-heavy solution
for such a small/isolated/hacky purpose. It may be better to spend that
development cycles on avoiding flushing TCP sockets that already
returned a zero-size read and do not need to be flushed. Please let me
know if you disagree (and I will not commit this patch).


Thank you,

Alex.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: do-not-empty-uds-buffers-t0.patch
Type: text/x-diff
Size: 2016 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160609/374ada4c/attachment.patch>