[squid-dev] [PATCH] Fix ssl use for kerberos_ldap_group

[Markus Moeller]

Hi Amos,

    I fixed the free_path following your suggestion.

    I run also 
indent -br -ce -i4 -ci4 -l80 -nlp -npcs -npsl -d0 -sc -di0 -psl  over it as 
it is C based code.  Is that the correct or is there another tool to format 
the code. Not sure which debug message lines you meant.

Thank you
Markus


-----Original Message----- 
From: Amos Jeffries
Sent: Thursday, July 14, 2016 12:58 PM
To: Markus Moeller ; squid-dev at lists.squid-cache.org
Subject: Re: [squid-dev] [PATCH] Fix ssl use for kerberos_ldap_group

On 3/07/2016 4:57 a.m., Markus Moeller wrote:
> Hi Amos,
>
>   Here is a small patch for cases SSL must be used to connect to an ldap
> server.
>

Looks okay, except for two minor things.

* some debug messages are missing a space between end of one sentence
and the '(' starting the next. Search for ".("

* what about xstrdup()'ing the output of getenv() so you can drop the
free_path variable and if-statements wrapping xfree() ?

Cheers
Amos

-------------- next part --------------
A non-text attachment was scrubbed...
Name: squid-trunk-klg-2.patch
Type: application/octet-stream
Size: 78149 bytes
Desc: not available
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160724/9113e93b/attachment-0001.obj>