[squid-dev] [PATCH] Collapse internal revalidation requests (SMP-unaware caches)

[Eduard Bagdasaryan]

2016-07-20 16:21 GMT+03:00 Amos Jeffries <squid3 at treenet.co.nz>:
 > * smpAware() is documented as indicating whether CF is allowed. Yet the
 > the new comment inside the loop of Store::Disks::smpAware() seems to be
 > saying the opposite.

As this patch says, collapsing for revalidation requests is not
supported for SMP-aware caches, i.e. if we have configured several
caches and even one of them is SMP-aware, the new feature should be
disabled.

 > * collapsing requires Transients to exist yes?
 >  So why disable Transients initialization when !smpAware() ?

Transients is not required for collapsing to work for:
* Non-SMP Squid.
* SMP Squid with SMP-unaware-caches(like if we had several independent
    Squid instances). In this configuration no sharing among workes
    is supposed. Since Transients is a sharing mechanism, it should be
    disabled in this case.


Eduard.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.squid-cache.org/pipermail/squid-dev/attachments/20160720/0aa306ab/attachment.html>