[squid-dev] [PATCH] Some failed transactions are not logged

[Eduard Bagdasaryan]

Hello Amos,

2016-07-17 12:34 GMT+03:00 Amos Jeffries <squid3 at treenet.co.nz>:
 >  can these URI be logged with url_regex ACLs on access_log lines?

No because ACLUrlStrategy::requiresRequest() returns true.

 > why is pipeline.back() being checked instead of pipeline.front() ?
 > [not saying its wrong yet, just asking for a good reason.]

Since the pipeline acts as a FIFO we need the last-added pipeline
element to check whether it uses connection. I.e., if we pipelined
several requests, the CONNECT request (if we got it) will be the last,
because it starts using connection.

 > logAcceptError() should use a distinct "error:" URI labeling this as a
 > TCP accept error, since it has nothing to do with HTTP state.
Something like "error:user-connection-establishment" or
"error:open-user-connection"?  What do you think?


Eduard.