[squid-dev] [PATCH] connections_encrypted ACL

[Christos Tsantilas]

On 01/12/2016 11:48 PM, Amos Jeffries wrote:
> On 13/01/2016 9:56 a.m., Alex Rousskov wrote:
>> On 01/12/2016 11:26 AM, Christos Tsantilas wrote:
>>
>>> Should we rename "connection_encryption" to "connection-encryption" ?
>>
>> IMO, we must rename for consistency sake: New directives
>> use_underscores. New directive options use-dashes.
>>
>
> Yes the service parameter option needs to use '-'.
> (For the ACL type '_' is correct though.)

renamed to connection-encryption.

>
> in src/acl/ConnectionsEncrypted.cc
> * debugs() says "received_encrypted" still. That is the only one.
> * same debug should say "accept" not "accepts"

ok on this.
>
> in src/cf.data.pre
> * since the ecap option is default-on, the way I have been documenting
> those options is with name/syntax:   blah[=off]

I did not do this fix.
The  blah[=off] implies that the "=value" is optional, but the 
ecap_service parsing code will produce a parse error if omitted.


>
> +1 with the those text polishes. I dont think this needs another round
> of audit.

Applied to trunk as r14489, r14490 and r14492

>
> Amos