[squid-dev] [PATCH] libsbuf

[Alex Rousskov]

On 02/25/2016 10:01 AM, Kinkie wrote:
> Hi all,
>   please find attached a the bundle implementing libsbuf (merge
> proposal from lp:~squid/squid/sbuflab).
> 
> It:
> - shuffles SBuf core files into src/sbuf and implements sbuf/libsbuf.la
> - refactors SBuf <-> String adaption functions into a separate header,
> increasing decoupling
> - reduces the list of stubs and libraries needed for SBuf unit tests
> - removes _DEPENDENCIES clauses from affected unit tests' Makefile.am

If possible, please do not call things foo/FooX.h. One foo is enough.

Is this v4.0-only change? Have you considered _not_ using a library (and
a whole new directory) for these few SBuf-related files? Why not just
include them in sources list using a Makefile variable?

What does libsbuf.la depend on? If it depends on src/mem/ perhaps it
should go there? Again, this SBuf-dedicated directory feels wrong (too
narrow-scoped), and MemBlob should not really be there (if it is so
narrowly scoped; what if I want MemBlob without SBuf)?

> +#include "SBuf.h"

You should #include SBuf.h the same way *everywhere*: sbuf/SBuf.h


These are not objections.

Alex.